Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-91] Add organization type signup #4684

Merged
merged 6 commits into from Nov 10, 2023
Merged

Conversation

bufke
Copy link
Contributor

@bufke bufke commented Oct 13, 2023

Description

Add new user field, organization type. This field can be enabled in Django admin constance settings.

Notes

Add organization type field to registration and profile page. The field is a dropdown with fixed options.

@notion-workspace
Copy link

@bufke bufke changed the base branch from main to beta October 13, 2023 20:01
@notion-workspace
Copy link

@notion-workspace
Copy link

@notion-workspace
Copy link

bufke and others added 2 commits October 26, 2023 15:35
- Add dropdown choices for organization_type
- Add placeholder for email
- Add organization_website to sign-up form
- Make organization_website and organization_type removable
  from signup page via Constance USER_METADATA_FIELDS
- Update 'Organization' label to 'Organization name'
- Update CSS layout and field order to match designs
@jnm jnm changed the base branch from beta to feature/tos November 8, 2023 18:02
@bufke bufke self-assigned this Nov 8, 2023
@bufke bufke marked this pull request as ready for review November 8, 2023 18:03
@bufke
Copy link
Contributor Author

bufke commented Nov 8, 2023

I cannot set myself as reviewer, but I need to review the latest commit.

…s-error-handling

Fix required user metadata fields error handling
@bufke
Copy link
Contributor Author

bufke commented Nov 9, 2023

@p2edwards when I test this, I don't see organization type on the account settings page. It appears on registration.

It's also missing a unit test.

@p2edwards
Copy link
Contributor

@bufke Account settings page will be another task / PR since it crosses into the single page app territory.
Test would be nice, though

@bufke bufke assigned RuthShryock and unassigned bufke and p2edwards Nov 9, 2023
@bufke bufke merged commit 4b782e2 into feature/tos Nov 10, 2023
1 of 4 checks passed
@RuthShryock RuthShryock deleted the add-organization-type-signup branch November 10, 2023 16:03
@p2edwards p2edwards mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants