New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK-91] Add organization type signup #4684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2edwards
force-pushed
the
add-organization-type-signup
branch
from
October 23, 2023 23:20
460bff8
to
d85d642
Compare
- Add dropdown choices for organization_type - Add placeholder for email - Add organization_website to sign-up form - Make organization_website and organization_type removable from signup page via Constance USER_METADATA_FIELDS - Update 'Organization' label to 'Organization name' - Update CSS layout and field order to match designs
p2edwards
force-pushed
the
add-organization-type-signup
branch
from
October 26, 2023 19:38
b10515e
to
4f32dda
Compare
I cannot set myself as reviewer, but I need to review the latest commit. |
…s-error-handling Fix required user metadata fields error handling
@p2edwards when I test this, I don't see organization type on the account settings page. It appears on registration. It's also missing a unit test. |
@bufke Account settings page will be another task / PR since it crosses into the single page app territory. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new user field, organization type. This field can be enabled in Django admin constance settings.
Notes
Add organization type field to registration and profile page. The field is a dropdown with fixed options.