New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix replaceSupportEmail function #4689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
LMNTL
requested changes
Oct 25, 2023
jsapp/js/envStore.ts
Outdated
Comment on lines
167
to
170
} catch (err) { | ||
const errorObj = err as FailResponse; | ||
handleApiFail(errorObj); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Pushed a fix :)
LMNTL
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Makes the constanse setting
SUPPORT_EMAIL
being displayed in error notifications.Notes
Changes here:
handleApiFail
fromjs/utils
tojs/api
js/utils
tojs/textUtils
, becausereplaceSupportEmail
requiresenvStore
, and importing it intojs/utils
is causing dependency errors. I created new file for general text related utility functions and moved ones that will not require refactor.envStore
is not usingactions
anymore, just making direct call withapi.ts
replaceSupportEmail
is using email from environment endpointgetEnvironment
Reflux action :)Related issues
Fixes #3910