[TASK-114] Split out AccountFieldsEditor from AccountSettingsRoute #4709
Conversation
magicznyleszek
changed the title
… (to be used also in different PR)
# Conflicts: # jsapp/js/account/accountSettingsRoute.tsx
to allow other pieces of code to correctly update the profile
| .k-select__error { | ||
| font-size: sizes.$x12; | ||
| line-height: 1.6; | ||
| font-weight: 400; | ||
| font-style: normal; | ||
| color: colors.$kobo-red; | ||
| margin-top: sizes.$x6; | ||
| } | ||
|
|
There was a problem hiding this comment.
Could this message get positioned somehow so that the layout doesn't jump when it appears/disappears? Also, it would be nice if the error state had the same red border as the TextBox (when unfocused).
There was a problem hiding this comment.
The layout jumping is actually consistent with how the TextBox error is being displayed. I think this will require us having similar errors in all the common components, and then unfiying the functionality.
There was a problem hiding this comment.
I added the styles for the select trigger (for all the types: outline, blue, and gray)
There was a problem hiding this comment.
I agree that it's consistent with how the TextBox works, but I wonder if keeping it consistent is worth it in this case - especially since the refactor of the of the KoboSelect fields makes them look more distinct from the TextBoxes. You could keep the same layout/position and avoid the content jumping by adding a very short animation to a height property/transform of the error message.
Still, I take your point - this shouldn't hold up this task👍I don't need it to give approval.
|
Note: the CI is consistently failing during the |
There was a problem hiding this comment.
Looking good! I have one last small change to request: the select elements on the old account profile could accept tab focus, but ones in this PR can't. It looks like adding tabindex={0} to bem.KoboDropdown (or some other appropriate element in the component tree) would fix that.
Checklist
Description
Internal code improvement in preparation for upcoming feture.
Notes
I will be needing
AccountFieldsEditorfor the TOS feature.Changes here:
AccountFieldsEditorthat displays a selected list of user metadata fields and allows editing their values (locally)AccountSettingsRouteis usingAccountFieldsEditornowKoboSelectkobo-commonversion to latest one (needed it for linter rules for enums)Needed for #4711