New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade django-allauth to 0.57.0 #4715
Conversation
…tend-refactor' into django-allauth-0-56-1
…socialaccounts can now live in the db
1 similar comment
MultipleObjectsReturned at /accounts/login/ You could probably develop a unit test for this as I don't think it matters what the social apps are. They can be fake junk as long as they are oidc. |
self.fields['provider_id'].required = True | ||
|
||
def clean_provider_id(self): | ||
reserved_keywords = ['kobo'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO if we are blocking in django admin, it would be fine to remove the "Please do not use kobo
as the id
value" check. But I'll defer to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, especially since the code to parse OIDC sub-providers has been removed - it's now guarding against an impossible-to-achieve state (at least for someone not trying to break it.)
Checklist
Notes
This PR bumps the version of
django-allauth
from 0.54.0 to 0.57.0 (changelog). The major benefit is that SSO providers are able to be configured directly from the django admin, instead of through environment variables.Since the
provider_id
field is required by the{% provider_login_url %}
field, and the model itself can't be changed from our side, this PR also makes theprovider_id
field mandatory in the allauth admin.