Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prevent users from saving an existing social application due to provider ID validation #4738

Merged
merged 1 commit into from Nov 27, 2023

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Nov 27, 2023

… provider ID validation

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Fixed a bug that prevent updating Social Applications in the admin.

Notes

This problem was introduced by the recent django-allauth changes (kpi#4715); the check to see if the provider and provider_id fields were unique didn't account for social applications that were being edited, just new ones. So adding a Social Application would work fine, but editing an existing Social Application and clicking 'Save' would fail with a validation error.

@LMNTL LMNTL added bug Things broken and not working as expected Back end labels Nov 27, 2023
Copy link
Member

@RuthShryock RuthShryock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RuthShryock RuthShryock merged commit 43e1559 into beta Nov 27, 2023
4 checks passed
@RuthShryock RuthShryock deleted the allauth-admin branch November 27, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back end bug Things broken and not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants