Don't prevent users from saving an existing social application due to provider ID validation #4738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… provider ID validation
Checklist
Description
Fixed a bug that prevent updating Social Applications in the admin.
Notes
This problem was introduced by the recent django-allauth changes (kpi#4715); the check to see if the
provider
andprovider_id
fields were unique didn't account for social applications that were being edited, just new ones. So adding a Social Application would work fine, but editing an existing Social Application and clicking 'Save' would fail with a validation error.