Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter subscription boolean #4721

Merged
merged 16 commits into from Nov 15, 2023

Conversation

RuthShryock
Copy link
Member

@RuthShryock RuthShryock commented Nov 8, 2023

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Newsletter subscription field for TOS feature

Notes

Added newsletter_subscription boolean to extra_details which reflects whether the user is subscribed to the newsletter.

To test:

  • navigate to the create an account page (should see a new field with checkbox to subscribe to the newsletter)
  • create a new user who is subscribed to the newsletter
  • after confirming the email and signing in, you should see newsletter_subscription: True in the /me endpoint

@RuthShryock RuthShryock changed the base branch from beta to feature/tos November 8, 2023 20:40
@RuthShryock RuthShryock changed the title Add newsletter subscription signup Add newsletter subscription to /me endpoint and signup Nov 8, 2023
@RuthShryock RuthShryock changed the title Add newsletter subscription to /me endpoint and signup Add newsletter subscription boolean Nov 8, 2023
@RuthShryock RuthShryock marked this pull request as ready for review November 8, 2023 22:25
Copy link

@RuthShryock
Copy link
Member Author

All the tests pass locally, build failure doesn't relate to this code: internal discussion .

@p2edwards p2edwards merged commit fe1c651 into feature/tos Nov 15, 2023
4 checks passed
@p2edwards p2edwards deleted the add-newsletter-subscription-signup branch November 15, 2023 16:12
@p2edwards p2edwards mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants