New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newsletter subscription boolean #4721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit deba09f.
RuthShryock
changed the title
Add newsletter subscription signup
Add newsletter subscription to /me endpoint and signup
Nov 8, 2023
RuthShryock
changed the title
Add newsletter subscription to /me endpoint and signup
Add newsletter subscription boolean
Nov 8, 2023
…dd-newsletter-subscription-signup
All the tests pass locally, build failure doesn't relate to this code: internal discussion . |
p2edwards
reviewed
Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Newsletter subscription field for TOS feature
Notes
Added
newsletter_subscription
boolean toextra_details
which reflects whether the user is subscribed to the newsletter.To test:
newsletter_subscription: True
in the/me
endpoint