Rename partial permissions variables #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(in preparation to add …PartialByResponses`)
7 tasks
LMNTL
requested changes
Jan 26, 2024
Comment on lines
+84
to
+97
| /** Names of checkboxes for partial permissions (the counterparts). */ | ||
| export type CheckboxNamePartialByUsers = | ||
| | 'submissionsViewPartialByUsers' | ||
| | 'submissionsEditPartialByUsers' | ||
| | 'submissionsValidatePartialByUsers' | ||
| | 'submissionsDeletePartialByUsers'; | ||
| /** All checkboxes names combined. */ | ||
| export type CheckboxNameAll = CheckboxNameRegular | CheckboxNamePartialByUsers; | ||
| /** Name of lists of usernames for a partial permissions checkboxes. */ | ||
| export type PartialByUsersListName = | ||
| | 'submissionsViewPartialByUsersList' | ||
| | 'submissionsEditPartialByUsersList' | ||
| | 'submissionsDeletePartialByUsersList' | ||
| | 'submissionsValidatePartialByUsersList'; |
There was a problem hiding this comment.
If you turned CheckboxNamePartialByUsers and PartialByUsersListName into enums, it looks like you could delete getPartialByUsersListName() and getPartialByUsersCheckboxName(). (A frozen const object would also work, but at that point it's just an enum with more steps.)
There was a problem hiding this comment.
Nice idea, I will try doing it on feature-extend-partial-perms--add-partial-by-responses as I think I have more of these functions there already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Internal cleanup
Notes
Renamed everything related to partial permissions (for a selected list of users) to make room for more partial permissions (for particular responses). So basically we use
…PartialByUsersinstead of…Partial, because we will be adding…PartialByResponses:)Needed for
feature/extend-partial-perms