Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode permissions labels #4734

Conversation

magicznyleszek
Copy link
Member

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Create a hardcoded list of permissions labels in preparation for upcoming feature.

Notes

Build on top of #4731 - together with this PR they are going to be used by #4733

Changes here:

  • Created a list of hardcoded labels (will extend it with more partial ones later)
  • Moved few functions to utils file
  • Split out some code into two utility functions for easier code reading and to update these in Feature: Extend Partial Perms #4733

Related issues

Requires #4731 to be merged first
Closes #4641 as no longer valid issue

@magicznyleszek magicznyleszek marked this pull request as ready for review November 21, 2023 21:24
jsapp/js/components/permissions/utils.ts Outdated Show resolved Hide resolved
Copy link

3 similar comments
Copy link

Copy link

Copy link

@magicznyleszek magicznyleszek merged commit cc21ead into rename-partial-permissions-variables Jan 31, 2024
4 checks passed
@magicznyleszek magicznyleszek deleted the hardcode-permissions-labels branch January 31, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants