Could not find attachment fix with filenames which contain non-latin characters.
#4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
force-pushed
the
fix-could-not-find-attachment
branch
from
e803ad5
to
0195a7a
Compare
jnm
approved these changes
Jan 22, 2024
| @@ -18,6 +19,14 @@ def get_kobocat_storage(): | |||
| return KobocatFileSystemStorage() | |||
|
|
|||
|
|
|||
| class DefaultKobocatStorage(LazyObject): | |||
There was a problem hiding this comment.
Interesting that this is only quasi-documented by Django. Seems safe to use, though 👍
There was a problem hiding this comment.
On second glance, the docstring for LazyObject says:
By subclassing, you have the opportunity to intercept and alter the
instantiation. If you don't need to do that, use SimpleLazyObject.
Would this suffice?
default_kobocat_storage = SimpleLazyObject(get_kobocat_storage)There was a problem hiding this comment.
FYI: I've replicated what Django is doing to instantiate default_storage.
But your solution is great. It's "Simple" and there is less code. 💯
…x/kpi into fix-could-not-find-attachment
LMNTL
requested changes
Jan 23, 2024
kpi/models/asset.py
Outdated
Comment on lines
549
to
550
| v = self.latest_deployed_version if deployed else self.latest_version | ||
| survey = v.to_formpack_schema()['content']['survey'] |
There was a problem hiding this comment.
I can mostly tell what this function is doing right now, so I don't think it's a huge deal, but adding (brand new) one-letter variables is a little scary. 😅
LMNTL
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
JS uses the new added property
question_xpathfrom data endpoint response to retrieve the correct attachment (instead of the attachment filename).Back-end should only try to add the property on the fly it is missing (see kobotoolbox/kobocat#915). It should cover existing data.
Related issues
Related to #3659
Related to kobotoolbox/kobocat#915