Fix 500 error when loading table view #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm
requested changes
Jan 30, 2024
kpi/models/asset.py
Outdated
Comment on lines
571
to
572
| if str(e).strip("'") != '$xpath': | ||
| raise e |
There was a problem hiding this comment.
I'm not a big fan of this when it's possible to isolate the logic that might generate the exception 🙈
For something like, say, handling an exception raised by a library like pyxform, when we need to distinguish between exceptions that have the same class, I'm fully okay with string comparisons.
There was a problem hiding this comment.
I'm not a big fan of this when it's possible to isolate the logic that might generate the exception 🙈 For something like, say, handling an exception raised by a library like pyxform, when we need to distinguish between exceptions that have the same class, I'm fully okay with string comparisons.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an error when - under certain circumstances - the table view does not load and display Server Error(500)
Notes
#4811 expected every Asset to have
$xpathinjected in its content. It may be not the case for old projects which have not been edited at least once since version2.022.44a. Therefore #4811 bug fix crashes on KeyError$xpath.