Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog to announce new features in the UI #4814

Merged
merged 13 commits into from Jan 23, 2024
Merged

Add dialog to announce new features in the UI #4814

merged 13 commits into from Jan 23, 2024

Conversation

duvld
Copy link
Member

@duvld duvld commented Jan 19, 2024

Description

Adds a new dialog component that can be placed on new features which may not stand out at first glance.

Notes

Dialog is a wrapper for whatever component needs to be featured. CSS places the dialog relative to the left-most part of the child. On close, the dialog adds a variable to localstorage and will not show again unless changed.

Related issues

Internal discussion:
https://chat.kobotoolbox.org/#narrow/stream/7-Kobo-UX.2FUI.2FProduct/topic/Project-level.20control.20of.20anonymous.20submission

Part of: #4728

@duvld duvld requested a review from LMNTL January 19, 2024 20:12
jsapp/js/stores.es6 Outdated Show resolved Hide resolved
jsapp/js/components/newFeatureDialog.module.scss Outdated Show resolved Hide resolved
jsapp/js/components/newFeatureDialog.module.scss Outdated Show resolved Hide resolved
@LMNTL LMNTL requested a review from jnm January 19, 2024 20:32
The new feature dialog used outdated wording; I've updated with the
exception of removing "web forms" from the copy. This feature applies to
*all* anonymous submissions, not just those made through Enketo web
forms. If further adjustment is needed, it can be done in a separate PR.

Internal discussion:
https://chat.kobotoolbox.org/#narrow/stream/7-Kobo-UX.2FUI.2FProduct/topic/Project-level.20control.20of.20anonymous.20submission/near/327893
Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good 👍 Thanks!

Copy link
Member

@jnm jnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, actually, there's an issue. The notification dismissal needs to be stored per user. I'll see if I can make a quick change myself. (If Patrick logs in, dismisses the notification, logs out, and later Kate logs in, Kate should still see the message.)

@jnm jnm changed the title Adds new dialog that can be placed on new features in the UI Adds dialog to announce new features in the UI Jan 23, 2024
@jnm jnm changed the title Adds dialog to announce new features in the UI Add dialog to announce new features in the UI Jan 23, 2024
@LMNTL LMNTL requested a review from jnm January 23, 2024 18:38
@jnm jnm changed the base branch from beta to release/next-jnm January 23, 2024 21:33
@jnm jnm changed the base branch from release/next-jnm to beta January 23, 2024 21:37
@jnm jnm merged commit 3754bbd into beta Jan 23, 2024
4 checks passed
@jnm jnm deleted the new-feature-dialog branch January 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants