Remove the Note qualitative analysis question type from exports

[RuthShryock]

Checklist

1. If you've added code that should be tested, add tests
2. If you've changed APIs, update (or create!) the documentation
3. Ensure the tests pass
4. Make sure that your code lints and that you've followed our coding style
5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
7. Open an issue in the docs if there are UI/UX changes

Notes

To test:

• Checkout beta and create a project with an audio question
• Submit a response and add a note in the analysis view
• Make an export and you can see an extra column created for the note
• Checkout this branch and restart your development environment
• Make another export of the project and confirm that note doesn't generate an extra column

[notion-workspace]

Remove the Note qualitative analysis question type from exports

[jnm]

Hey @RuthShryock, thanks for working on this. Since the this method, analysis_form_json(), is not specific to exports and is also used to generate API responses, could you please:

1. Add a new parameter to this method; let's call it omit_question_types. This should be able to take a list of types that should be skipped.
2. Make the default value for the parameter None
   • It might seem like we should use an empty list ([]) as the default, but see https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments for reason why we shouldn't :)
3. Change your logic to continue if field['type'] matches any of the types in omit_question_types
4. Find where analysis_form_json() is called by the export code, and pass omit_question_types=['qual_note'] to it there.

Let me know if you have any questions :)

[jnm]

Awesome, thank you 🎉