FR: Circular Ride v2 improvement suggestions #22
Labels
enhancement
New feature or request
Comments
fractalgee
changed the title
|
I have built in sync. First test look positive. |
|
That works! thanks. Now, how about some CV ins over all those knobs? CV all
the things is a good mantra in modular after all...No rush of course, but
now i want to modulate the delay times lol.....at least, the rest could
also be good as sound design tools.....
Anyhow. They look great, seem to work as advertised so great job on this!
Thanks!
…On Sun, 21 Nov 2021 at 14:55, kockie69 ***@***.***> wrote:
I have built in sync. First test look positive.
If you build from this repo can you test it for me?
https://github.com/kockie69/RPJ/tree/FR-Issue-22
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMABJJA6PXPNA2ERHKY3UND25DANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I can add the cv's to the delays, although I think that will create some probably unwanted side effects. But let me add that and see where we go from there |
|
Sounds good. It is just always good to have CV control over any of the things (of course stoermelder mapping tools to rescue if not) but modular is made to CV after all.....
|
|
New version available with cv's for delay params. |
|
As Omar would say, Proper!
nice one, think about the others too, feedback for example and
dry/wet/lpf/hpf would also be cool. still space on that panel ;)
lovely. Makes me miss the Chronoblob2 less :D
…On Sun, 21 Nov 2021 at 15:57, kockie69 ***@***.***> wrote:
New version available with cv's for delay params.
https://github.com/kockie69/RPJ/tree/FR-Issue-22
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMACXLMBJPB6KJV2CQ6LUNECE5ANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Yes, let me work on that. Maybe a bit of promotion on this module might help too ;-) |
|
OK, all cv's are implemented. Have a look and let me know your thoughts..... |
|
Seems to work fine and looks good. thanks! Will play more next days, but no issues thus far, am currently modulating center delay time for nice slow evolving effect. Will work on a patch promoting this one, as it stars to work just like the Chronoblob2 in ping-pong and normal mode. Very cool, I can live with this as a replacement just fine |
|
I will close this issue for now. If you experience any issues during your test feel free to raise a new issue. |
|
all good, thanks
…On Sun, 21 Nov 2021 at 18:46, kockie69 ***@***.***> wrote:
Closed #22 <#22>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMAA2G7LRT6DGSYSIBBTUNEWA5ANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
BTW, Omri Cohen wants to test it ;) so I did promote it a bit Can I give him my build? Or will you make a win build for him? If you are OK I can give him my build to test |
|
You can give him your build, no problem. Thanks for promoting this!
Op zo 21 nov. 2021 om 20:12 schreef fractalgee ***@***.***>:
… BTW, Omri Cohen wants to test it ;) so I did promote it a bit Can I give
him my build? Or will you make a win build for him? If you are OK I can
give him my build to test
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATNMDPZODAX5HORDTKY4SDUNFHBPANCNFSM5IO7FCYA>
.
|
|
I have made a small update. The parameters for the filters (LPF/HPF) were not optimal, this has been improved now. You might want to give Omri an updated version if he is also testing the LCRDelay. |
|
ok, will do, rebuilding shortly after fresh pull
…On Mon, 22 Nov 2021 at 01:03, kockie69 ***@***.***> wrote:
I have made a small update. The parameters for the filters (LPF/HPF) were
not optimal, this has been improved now. You might want to give Omri an
updated version if he is also testing the LCRDelay.
https://github.com/kockie69/RPJ/tree/v2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMADLQJOAYUZDWTQF2ZTUNGCGRANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
no issues so all good as far as I can tell, loving the Circular Ride
Sent the updated build to Omri as well
…On Mon, 22 Nov 2021 at 08:07, Georg Carlson ***@***.***> wrote:
ok, will do, rebuilding shortly after fresh pull
On Mon, 22 Nov 2021 at 01:03, kockie69 ***@***.***> wrote:
> I have made a small update. The parameters for the filters (LPF/HPF) were
> not optimal, this has been improved now. You might want to give Omri an
> updated version if he is also testing the LCRDelay.
>
> https://github.com/kockie69/RPJ/tree/v2
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#22 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC7FMADLQJOAYUZDWTQF2ZTUNGCGRANCNFSM5IO7FCYA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
|
2.0.4's and 2.0.3's filters don't do a thing I am sad to report. Hope
nothing too major that needs fixing.... Just confirmed with scope and
oscilloscope that indeed, sound does not change if knobs turned and/or CV
is fed in.... Both LPF and HPF have that issue Do I need to send audio
through those CV ins? Not tried that I just realized when I tested earlier
…On Mon, 22 Nov 2021 at 12:04, Georg Carlson ***@***.***> wrote:
no issues so all good as far as I can tell, loving the Circular Ride
Sent the updated build to Omri as well
On Mon, 22 Nov 2021 at 08:07, Georg Carlson ***@***.***> wrote:
> ok, will do, rebuilding shortly after fresh pull
>
> On Mon, 22 Nov 2021 at 01:03, kockie69 ***@***.***> wrote:
>
>> I have made a small update. The parameters for the filters (LPF/HPF)
>> were not optimal, this has been improved now. You might want to give Omri
>> an updated version if he is also testing the LCRDelay.
>>
>> https://github.com/kockie69/RPJ/tree/v2
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <#22 (comment)>, or
>> unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AC7FMADLQJOAYUZDWTQF2ZTUNGCGRANCNFSM5IO7FCYA>
>> .
>> Triage notifications on the go with GitHub Mobile for iOS
>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android
>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>>
>
|
|
In case that gets misread, Circular Ride's LPF/HPF
…On Tue, 23 Nov 2021 at 16:08, Georg Carlson ***@***.***> wrote:
2.0.4's and 2.0.3's filters don't do a thing I am sad to report. Hope
nothing too major that needs fixing.... Just confirmed with scope and
oscilloscope that indeed, sound does not change if knobs turned and/or CV
is fed in.... Both LPF and HPF have that issue Do I need to send audio
through those CV ins? Not tried that I just realized when I tested earlier
On Mon, 22 Nov 2021 at 12:04, Georg Carlson ***@***.***> wrote:
> no issues so all good as far as I can tell, loving the Circular Ride
> Sent the updated build to Omri as well
>
> On Mon, 22 Nov 2021 at 08:07, Georg Carlson ***@***.***> wrote:
>
>> ok, will do, rebuilding shortly after fresh pull
>>
>> On Mon, 22 Nov 2021 at 01:03, kockie69 ***@***.***> wrote:
>>
>>> I have made a small update. The parameters for the filters (LPF/HPF)
>>> were not optimal, this has been improved now. You might want to give Omri
>>> an updated version if he is also testing the LCRDelay.
>>>
>>> https://github.com/kockie69/RPJ/tree/v2
>>>
>>> —
>>> You are receiving this because you authored the thread.
>>> Reply to this email directly, view it on GitHub
>>> <#22 (comment)>, or
>>> unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/AC7FMADLQJOAYUZDWTQF2ZTUNGCGRANCNFSM5IO7FCYA>
>>> .
>>> Triage notifications on the go with GitHub Mobile for iOS
>>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>>> or Android
>>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>>
>>>
>>
|
|
They only work with the LCRDelay algorithm. Have you selected that one?
I tried it and of course it is working for me (like always ;-)).
|
|
Seems odd they are only working with the newly added one, any way to also
get em to work in all the others (that are there and/or the ones you are
planning to add?
…On Tue, 23 Nov 2021 at 16:47, kockie69 ***@***.***> wrote:
They only work with the LCRDelay algorithm. Have you selected that one?
Op di 23 nov. 2021 om 15:09 schreef fractalgee ***@***.***>:
> In case that gets misread, Circular Ride's LPF/HPF
>
> On Tue, 23 Nov 2021 at 16:08, Georg Carlson ***@***.***> wrote:
>
> > 2.0.4's and 2.0.3's filters don't do a thing I am sad to report. Hope
> > nothing too major that needs fixing.... Just confirmed with scope and
> > oscilloscope that indeed, sound does not change if knobs turned and/or
CV
> > is fed in.... Both LPF and HPF have that issue Do I need to send audio
> > through those CV ins? Not tried that I just realized when I tested
> earlier
> >
> >
> >
> > On Mon, 22 Nov 2021 at 12:04, Georg Carlson ***@***.***> wrote:
> >
> >> no issues so all good as far as I can tell, loving the Circular Ride
> >> Sent the updated build to Omri as well
> >>
> >> On Mon, 22 Nov 2021 at 08:07, Georg Carlson ***@***.***> wrote:
> >>
> >>> ok, will do, rebuilding shortly after fresh pull
> >>>
> >>> On Mon, 22 Nov 2021 at 01:03, kockie69 ***@***.***> wrote:
> >>>
> >>>> I have made a small update. The parameters for the filters (LPF/HPF)
> >>>> were not optimal, this has been improved now. You might want to give
> Omri
> >>>> an updated version if he is also testing the LCRDelay.
> >>>>
> >>>> https://github.com/kockie69/RPJ/tree/v2
> >>>>
> >>>> —
> >>>> You are receiving this because you authored the thread.
> >>>> Reply to this email directly, view it on GitHub
> >>>> <#22 (comment)>,
> or
> >>>> unsubscribe
> >>>> <
>
https://github.com/notifications/unsubscribe-auth/AC7FMADLQJOAYUZDWTQF2ZTUNGCGRANCNFSM5IO7FCYA
> >
> >>>> .
> >>>> Triage notifications on the go with GitHub Mobile for iOS
> >>>> <
>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> >>>> or Android
> >>>> <
>
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
> >.
> >>>>
> >>>>
> >>>
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#22 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AATNMDJZELJMWKWUMBQUHV3UNOVDNANCNFSM5IO7FCYA
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMAHQ7CE3OL4ZGY5A5HLUNOZR3ANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
The point is that I implement ' standard' algorithms and the first two don't have filtering in their feedback so that's not implemented. But maybe I have to say (kind of by default) every feedback will have filtering which for the user is much more clear. Agree. Ok, nice improvement for tonight. |
|
Excellent, thanks for listening, Omri also found the filters not working in
the standard algos, so he wasn't too impressed by what I got.
We are all in this together after all, and collaboration is much better
than competition any time in my book.
…On Tue, 23 Nov 2021 at 17:57, kockie69 ***@***.***> wrote:
The point is that I implement ' standard' algorithms and the first two
don't have filtering in their feedback so that's not implemented. But maybe
I have to say (kind of by default) every feedback will have filtering which
for the user is much more clear. Agree. Ok, nice improvement for tonight.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMAGP22OQVUTBI3FVKNDUNPBY5ANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
a couple of things:
If I switch to the new delay type the letters in the display run
together, so it is impossible to read what algo is active. That display
issue needs fixing.
Also, if I touch the LPF knb when I have Caudal out #3 connected to it's CV
it goes into overload on the mixer until I turn mixer level down (master!)
works after that to set it back up to where it was. glitches sometimes when
I move any knob. so seems it's not fading from one to next value, might
also be handy
…On Tue, 23 Nov 2021 at 18:21, Georg Carlson ***@***.***> wrote:
Excellent, thanks for listening, Omri also found the filters not working
in the standard algos, so he wasn't too impressed by what I got.
We are all in this together after all, and collaboration is much better
than competition any time in my book.
On Tue, 23 Nov 2021 at 17:57, kockie69 ***@***.***> wrote:
> The point is that I implement ' standard' algorithms and the first two
> don't have filtering in their feedback so that's not implemented. But maybe
> I have to say (kind of by default) every feedback will have filtering which
> for the user is much more clear. Agree. Ok, nice improvement for tonight.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#22 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC7FMAGP22OQVUTBI3FVKNDUNPBY5ANCNFSM5IO7FCYA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
|
Spoke too soon, even worse, it is stuck in full out, and the comp is
squashing it 100% hence no sound. Switch back to PingPong and sound returns
…On Tue, 23 Nov 2021 at 19:12, Georg Carlson ***@***.***> wrote:
a couple of things:
If I switch to the new delay type the letters in the display run
together, so it is impossible to read what algo is active. That display
issue needs fixing.
Also, if I touch the LPF knb when I have Caudal out #3 connected to it's
CV it goes into overload on the mixer until I turn mixer level down
(master!) works after that to set it back up to where it was. glitches
sometimes when I move any knob. so seems it's not fading from one to next
value, might also be handy
On Tue, 23 Nov 2021 at 18:21, Georg Carlson ***@***.***> wrote:
> Excellent, thanks for listening, Omri also found the filters not working
> in the standard algos, so he wasn't too impressed by what I got.
> We are all in this together after all, and collaboration is much better
> than competition any time in my book.
>
> On Tue, 23 Nov 2021 at 17:57, kockie69 ***@***.***> wrote:
>
>> The point is that I implement ' standard' algorithms and the first two
>> don't have filtering in their feedback so that's not implemented. But maybe
>> I have to say (kind of by default) every feedback will have filtering which
>> for the user is much more clear. Agree. Ok, nice improvement for tonight.
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <#22 (comment)>, or
>> unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AC7FMAGP22OQVUTBI3FVKNDUNPBY5ANCNFSM5IO7FCYA>
>> .
>> Triage notifications on the go with GitHub Mobile for iOS
>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android
>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>>
>
|
|
I think/hope I already fixed that LPF issue as I spotted an error when I started looking at the code to work on the filters. I need to test it but I will get back to you on that when the filters are implemented for all the algos. |
fractalgee
changed the title
|
Here is what it looks like at 100% zsoom, 150 is no better. The other two algos show fine. I am on Windows 10 |
|
This says LCRDelay, nothing wrong :-) But I will change the spacing so it will be less compact |
|
yes, it was just too squashed (and I am getting older ;) )
…On Tue, 23 Nov 2021 at 20:39, kockie69 ***@***.***> wrote:
This says LCRDelay, nothing wrong :-) But I will change the spacing so it
will be less compact
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMAAM5CPE4J2TKIDUEHTUNPUXPANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
https://github.com/kockie69/RPJ/tree/issue-29 Can you check this one? I think this one does what we want. |
|
OK, built and briefly tested on current patch. Seems to do something now
but need to work out in scope/oscilloscope what effect it now has. Tomorrow
for that though.
…On Tue, 23 Nov 2021 at 22:00, kockie69 ***@***.***> wrote:
https://github.com/kockie69/RPJ/tree/issue-29
Can you check this one? I think this one does what we want.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMAFQRCVJSILR56MHT4TUNP6FLANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
OK, did you actually push those changes? Seems to still be non-functional filter-wise, the rest seems OK as far as I can tell. But one can twiddle the LPF/HPF knobs at will and sound does not change coming out of Circular Ride, waveform on oscilloscope also does not change, so no filtering seems to take place. Also tried the new algo, still get no response from filters... |
|
They are pushed into issue-29 branch (https://github.com/kockie69/RPJ/tree/issue-29), so make sure you are building that one it is not (yet) on the v2 . |
|
aha! Okidoki, retesing and yes, I built that branch, so should have all the
fixes. My bad, that was a misunderstanding on my part.
…On Wed, 24 Nov 2021 at 08:54, kockie69 ***@***.***> wrote:
They are pushed into issue-29 branch (
https://github.com/kockie69/RPJ/tree/issue-29), so make sure you are
building that one it is not (yet) on the v2 .
Also, the filters are only in the feedback, so without feedback you will
see no effect (and of course make sure you have them enabled in the menu)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7FMAGQRRTSLMW6GL5NZOLUNSK4VANCNFSM5IO7FCYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Alright, that works nicely! Merge back to v2 branch at will and make a new build when you have time please. As the Chronoblob also has a beta release since early this morning my time ;) |
|
That is all done. We now have a v2.0.5 which includes the latest CircularRide. |
|
That LCR Delay algo is the bee's knees! I have CR now fading in and out, sometimes providing bursts of delays and the Chronoblob in default send delay duty. Lovey that. Great stuff. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a feature request to add a sync/clock input to Circular Ride so it can be easily synced
The text was updated successfully, but these errors were encountered: