-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pigeon Plink to patch crashes Rack. #46
Comments
The RPJ.json file is not needed, it is optional. You can add it yourself to add steppings ( or remove steppings). If it doesn't exist it will use the default settings that are hard-coded in the module. I checked for the handling of the message and that looks wrong in the code. Even though there is no RPJ.json file, it still says it is loading the file. So the cause of the crash is something else. Can you send me your complete logfile after a crash? |
Same thing happens for me, also on linux. |
@spectromas or @ExistentiaVirae , are you able (do you know how) to install the plugin manually so you can test a newer version? If so, can you please pick aversion from here and install? |
log.txt I could build/install a copy manually to test, if you tell me which branch to clone. |
Sorry, forgot to add the link. You don't have to build, it is already done. You can pick it from here: https://github.com/kockie69/RPJ/actions/runs/1733265194 Let me know if you need help |
Same thing for me with the beta as far as I can tell.
|
I got this:
|
Ok, I have removed the possibility to add your own configs for now to see if that fixes the bug. Can you please try this version (sorry for the inconvenience): |
No worries, happy to help! Still crashing:
|
Thanks for helping. Well , looks like we have a completely different error message now. |
The latest build works fine for me. |
Can you both test this version ? |
@spectromas : Have you used Kitchen Sink before from Squinky Labs? Is that module working for you? And can you let me know on what linux distro you are? |
Yeah, it died with this:
|
So the version without the config actually did work ok for me. I originally loaded it in the patch I had been using (an old v1 patch) and it crashed but after starting a new patch allowed me to load the module. Now with the last version I get this:
I'm using Arch and don't have any problems with Kitchen Sink. |
@spectromas , I asked that question because you had raised that error (but apparently it wasn't there) and that message reflected to some Kitshen Sink code, that was the reason I was asking. |
Alright, I have a new version that can be tested: https://github.com/kockie69/RPJ/actions/runs/1733477380 Fingers crossed it works this time |
It works as expected this time. |
Alright, lets wait for confirmation from @spectromas too. Hopefully it also works at that side.... |
I'm not really sure what's happening. With this latest: previously had Rack crashed so I said yes to clearing the patch, then opened the module and no problem. Then I went to New to open my template and then Rack crashes when I try to load the module. So I tried again but this time starting with my template, the module loaded with no problem. However, I went to New to reopen my template and tried to load the module and it crashed.
|
I keep asking about Kitchen Sink, sorry :-) Is it possible to share your template? |
I don't have kitchen sink in my template but there are two Comp IIs. It does seem to be that that causes the crash. |
I think someone mentioned something about two compII's in a patch somewhere on the forum. It wasn't raised here as an issue so I did not yet dive into it (mainly because I was trying to get the Pigeon Plink released). |
Yes, it seems so. When the comps aren't in the patch I can't make it crash. Should I open a report on your squinky repo? |
Yes please. That also gives other the opportunity to follow the status. Thank you. |
This has been fixed and released in v2.1.1 |
Every time I attempt to add Pigeon Plink, Rack closes itself. These seem to be the pertinent lines in log.txt:
There is no RPJ.json file. I suspect that may be the root cause of the problem.
This was on Kubuntu 20.04 and VCV Rack Free v2.0.6
The text was updated successfully, but these errors were encountered: