Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TuxOn problems #59

Closed
DaveBenham opened this issue Jun 13, 2022 · 9 comments · Fixed by #60
Closed

TuxOn problems #59

DaveBenham opened this issue Jun 13, 2022 · 9 comments · Fixed by #60
Assignees
Labels
bug Something isn't working

Comments

@DaveBenham
Copy link

Windows and Macintosh:

  • Zoom In and Zoom Out not doing anything
  • Limited song length
    • If song long enough, then impossible to play entire song
    • VCV sample rate affects how much can be played, but sound quality remains same. For example, I have a ~3:50 mp3 recorded at 48k that can be played in its entirety if VCV sample rate is at 48k. If at 96k then only ~2:50 plays, though entire songs is graphically displayed - it just simply stops playing before reaching end. VCV at 192k only plays ~1:25.

Macintosh only

  • VCV Rack crashes after playing a song when I try to load a new patch. Also, VCV does not shut down properly if I try to close after playing a song
  • Eject does not work, neither does selecting a new song via the context menu
@kockie69
Copy link
Owner

kockie69 commented Jun 14, 2022

Hi Dave, not sure if you are handling the zoom function in the right way. You need to change the start and end first (or one of the two). Than you can drill. Otherwise it doesn't know to drill within which interval.

I will look into the other issues.

@DaveBenham
Copy link
Author

Well that makes sense. Sounds like good info for the documentation ;-)

The zoom in behavior surprises me. Currently the start and end positions change each time you press zoom in. By that I mean the points in the song that they represent change upon each zoom in - call that the play zone.

I would expect the play zone to remain constant, meaning that after the zoom in operation, the start and end lines would be at the outer edges of the zoomed in area.

@kockie69
Copy link
Owner

kockie69 commented Jun 14, 2022 via email

@kockie69 kockie69 added the bug Something isn't working label Jun 15, 2022
@kockie69 kockie69 self-assigned this Jun 15, 2022
@kockie69 kockie69 linked a pull request Jun 17, 2022 that will close this issue
@kockie69
Copy link
Owner

kockie69 commented Jun 18, 2022

Hi Dave, you said

I would expect the play zone to remain constant, meaning that after the zoom in operation, the start and end lines would be at the outer edges of the zoomed in area.

And I agreed. But........
Whilst implementing I ran into the issue that the begin and end knobs don't reset to the full left and full right respectively when zooming in. That means (for example for begin) according to the display you can go the right but your knob can't anymore.

I don't have a solution yet, happy to hear your thoughts.

@DaveBenham
Copy link
Author

It took me a few moments to understand your point, but I got there. I know there have been a few modules that move the knobs, but not many.

It is a little awkward, because the begin/end markers represent two different values - the position on the screen, and the position within the mp3.

I'm not sure if this is the correct term, but I'm thinking it would make sense to use a "rotary encoder" knob, where it can spin "infinitely" in either direction. The amount you spin the knob dictates how far it moves. You wouldn't have to reset the knobs with that type of control.

@kockie69
Copy link
Owner

kockie69 commented Jun 18, 2022 via email

@kockie69
Copy link
Owner

Dave, I have fixed the issues, except for the specific Mac ones.
Are you happy/able to test the fixes for me? You can download a version from here.

https://github.com/kockie69/RPJ/actions/runs/2530109697

@DaveBenham
Copy link
Author

Sure. I'll take a look either today or tomorrow

@DaveBenham
Copy link
Author

Yep - the Mac issues are still there. But the song length and zoom are now working perfectly on both Mac and PC. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants