Out of bounds array access

[cschol]

I started running static analysis with cppcheck as part of the integration process and it found this potential out of bounds array access.

I am not holding integration, but please check it out for the next release. Thanks!

Checking Grendel.cpp ...             
32/60 files checked 34% done
GenieExpander.cpp:31:10: error: Array 'colors[4][3]' accessed at index colors[4][*], which is out of bounds. [arrayIndexOutOfBounds]
   colors[i][j]=rnd(generator);
         ^                  
GenieExpander.cpp:29:16: note: Assuming that condition 'i<=4' is not redundant
 for (int i=0;i<=4;i++)                                                                                                                                    
               ^            
GenieExpander.cpp:31:10: note: Array index out of bounds
   colors[i][j]=rnd(generator);  
         ^          
GenieExpander.cpp:343:10: error: Array 'edges[4][2]' accessed at index edges[*][3], which is out of bounds. [arrayIndexOutOfBounds]
    edges[i][n]=rdMsg->edges[i][n];                                                                                                                        
         ^                                                                                                                                                 
GenieExpander.cpp:342:18: note: Assuming that condition 'n<4' is not redundant                                                                             
   for (int n=0;n<4;n++)         
                 ^                                                                                                                                         
GenieExpander.cpp:343:10: note: Array index out of bounds
    edges[i][n]=rdMsg->edges[i][n];
         ^                                                                                                                                                 
GenieExpander.cpp:343:29: error: Array 'rdMsg->edges[4][2]' accessed at index rdMsg->edges[*][3], which is out of bounds. [arrayIndexOutOfBounds]          
    edges[i][n]=rdMsg->edges[i][n];  
                            ^
GenieExpander.cpp:342:18: note: Assuming that condition 'n<4' is not redundant                                                                             
   for (int n=0;n<4;n++)                                                                                                                                   
                 ^                                                                                                                                         
GenieExpander.cpp:343:29: note: Array index out of bounds                                                                                                  
    edges[i][n]=rdMsg->edges[i][n];                                                                                                                        
                            ^      

[kockie69]

Closing this one, as it has been fixed in the past. Let me know if there is more.