Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal cross-chain sorting #3138

Closed
Tracked by #660 ...
vikiival opened this issue Jun 9, 2022 · 2 comments
Closed
Tracked by #660 ...

Universal cross-chain sorting #3138

vikiival opened this issue Jun 9, 2022 · 2 comments
Labels
$ ~<50usd 🧙‍♀️ - bug-hunt A-basilisk issues related to basilisk parachain A-research we will research on these bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@vikiival
Copy link
Member

vikiival commented Jun 9, 2022

I have a feeling that most of the sorting simply does not work

It would be nice to:

  • go through the app
  • check what does not work
  • fix it :)

I think there is a ton of incompatibility issues between the subquery and subsquid stuff (feel free to help me with packages/uniquery)

@roiLeo reported in #3039 that:

  • Sorting in /bsx/collection/{id} is broken
@vikiival vikiival added bug Something isn't working A-research we will research on these A-basilisk issues related to basilisk parachain labels Jun 9, 2022
@yangwao yangwao added $ ~<50usd p1 preventing everyone from using app 🧙‍♀️ - bug-hunt labels Jun 17, 2022
@petersopko petersopko mentioned this issue Jun 18, 2022
89 tasks
@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p1 preventing everyone from using app labels Jul 22, 2022
@petersopko petersopko mentioned this issue Aug 8, 2022
20 tasks
@yangwao yangwao mentioned this issue Aug 16, 2022
9 tasks
@petersopko
Copy link
Contributor

There are only couple things left when it comes to Basilisk, which need to be figured out. I know we've talked about this elsewhere, but regardless:

  1. Recently Interacted and Unpopular are doing the same thing as Recently Created and Oldest. The reason for this (as far as I can tell) is that activity such as Offer isn't changing the updatedAt of the NFT, therefore, the NFT get's updated only once and that's when it's created. This filter was created to sort by emotes -> this is irrelevant on BSX and we should hide it on both /snek and /bsx (I've checked just now and all of the Basilisk NFTs have updatedAt and createdAt are equal everywhere, regeradless of activity)
  2. Serial Number Ascending - in my opinion, this filter is more of a mystery than any added value -> I don't think people know what is this for and I don't think they care for having it. Oldest should be enough to sort by createdAt -> let's hide this on both /snek and /bsx

@vikiival
Copy link
Member Author

Please open issues in the snek repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd 🧙‍♀️ - bug-hunt A-basilisk issues related to basilisk parachain A-research we will research on these bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

3 participants