Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3F M1 Deliverables #221

Closed
vikiival opened this issue Feb 16, 2024 · 0 comments · Fixed by #194
Closed

W3F M1 Deliverables #221

vikiival opened this issue Feb 16, 2024 · 0 comments · Fixed by #194
Assignees

Comments

@vikiival
Copy link
Member

as per https://github.com/w3f/Grant-Milestone-Delivery/blob/7c2a1374ecbc5e329a57eba6aa08061876f5e99b/evaluations/kodadot_assethub_indexer_m1.md

General Notes

The application stated that there will be comprehensive inline documentation but nearly every deliverable is completely without inline documentation. This should be added. Both in the actual code and in the graphQL schemas.

4b. On-chain Attributes Handlers

type Attribute @jsonField {

What does this schema relate to? Can you please point me at the on-chain structure it should represent?

7a. Fungible Assets Schema Creation

type AssetEntity @entity {

Shouldn't the fungible asset schema contain more features? I would expect the schema to represent all information available for this fungible asset. See the following images from polkadot.js/apps to see what I would expect:
Bildschirm­foto 2024-02-15 um 12 40 12

7b. Fungible Assets Force Creation

This only works for system tokens that are not yet ported to assetHub, doesn't it?

Link to 7c correct?

Fungible Assets CREATE Event
links to

which is part of the forceToken.ts file still and doesn't look like a handler for regular "create fungible asset" events.

Difference between 10a and 1b?

Why was this listed twice as deliverable if there is no difference?

@vikiival vikiival self-assigned this Feb 16, 2024
@vikiival vikiival linked a pull request Feb 28, 2024 that will close this issue
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant