Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code not recompiled on change #155

Closed
carlito767 opened this issue Aug 18, 2018 · 11 comments
Closed

Source code not recompiled on change #155

carlito767 opened this issue Aug 18, 2018 · 11 comments

Comments

@carlito767
Copy link

Hi,

I recently updated my project to the latest Kha and the source code is not recompiled on change anymore. Here is the batch file used to build the project:

pushd ..
start /B node Kha/make html5 --watch
start /B node Kha/make --server
popd

It seems related to this revision.

@RobDangerous
Copy link
Member

chokidar is the dependency responsible for watching for file changes, see if updating that helps.

@carlito767
Copy link
Author

I updated all modules (including chokidar 2.0.4) but same issue.
Could you confirm you have the problem (to be sure it's not only on my side)?

@RblSb
Copy link
Contributor

RblSb commented Aug 18, 2018

The last working commit for you is this?

@carlito767
Copy link
Author

carlito767 commented Aug 18, 2018 via email

@RblSb
Copy link
Contributor

RblSb commented Aug 19, 2018

@carlito767 You can try install old chokidar version and set it in package.json for latest khamake, perhaps it will give some results.

@carlito767
Copy link
Author

When I come back to chokidar@1.7.0, it works. But it fails with the next release (chokidar@2.0.0).

@RobDangerous
Copy link
Member

I can not reproduce your problems but this is a good data point. I'll look into removing chokidar, it also has problems with specific chars in paths which haven't been fixed in years.

@RblSb
Copy link
Contributor

RblSb commented Aug 20, 2018

@carlito767 You might want to check 15 chockidar commits to identify the problem (this is 4 tests if you start from the middle of the groups)
paulmillr/chokidar@1.7.0...2.0.0
If you find, report the issue in their repo.

@RblSb
Copy link
Contributor

RblSb commented Aug 21, 2018

Also, try this khamake branch https://github.com/RblSb/khamake/tree/chokidar_fix

@RblSb
Copy link
Contributor

RblSb commented Aug 21, 2018

I found that chokidar 2.0 supports only posix slashes, so this actually should help.

@carlito767
Copy link
Author

I tried your fix and it works! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants