Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A library's full path is used for addDefine #232

Open
MoritzBrueckner opened this issue Sep 13, 2020 · 0 comments
Open

A library's full path is used for addDefine #232

MoritzBrueckner opened this issue Sep 13, 2020 · 0 comments

Comments

@MoritzBrueckner
Copy link
Contributor

MoritzBrueckner commented Sep 13, 2020

When adding a library in the Khafile like this:

project.addLibrary("D:/dev/armsdk/armory");

The hxml define looks like this:

-D D:/dev/armsdk/armory

instead of this:

-D armory

This is especially problematic when the Khafile uses absolute paths and is automatically generated like Armory does it. The flag will likely be different on different machines so there is no way to use it properly in the code.

khamake/src/Project.ts

Lines 207 to 208 in 25a96e9

addLibrary(library: string): string {
this.addDefine(library);

Link with armory3d/armory#1858 (comment)

@MoritzBrueckner MoritzBrueckner changed the title A libraries full path is used for addDefine A library's full path is used for addDefine Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant