Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendertarget samples broken with G4onG5 #864

Open
SunDaw opened this issue Feb 18, 2024 · 3 comments
Open

Rendertarget samples broken with G4onG5 #864

SunDaw opened this issue Feb 18, 2024 · 3 comments

Comments

@SunDaw
Copy link
Contributor

SunDaw commented Feb 18, 2024

Describe the bug
Several render target samples from https://github.com/Kode/Kinc-Samples crash with G4onG5 backends (tested with both D3D12 and Vulkan).

To Reproduce
Steps to reproduce the behavior:

  1. Clone https://github.com/Kode/Kinc-Samples
  2. Build either of 06_render_targets, 07_multiple_render_targets or 08_float_render_targets
  3. Run executable, crashes on first update call

Expected behavior
Samples should work the same way they do with Direct3D11/OpenGL backends

Execution Environment:

  • Host system (where you compile your code): Windows 10 Home 22H2
  • Target system (where you run your code): Windows 10 Home 22H2
  • IDE and/or compiler used: MSVC 17.9.0
  • Kinc revision: 3525720

Additional context
Callstack shows crash in "G4.c.h" startDraw on memcpy(current_state.vertex_constant_data, vertexConstantBuffer.data, constantBufferSize); because vertexConstantBuffer.data is a nullpointer

Example.exe!memcpy() Line 304 Unknown
Example.exe!startDraw(bool compute) Line 167 C
Example.exe!kinc_g4_draw_indexed_vertices() Line 264 C
Example.exe!update(void * data) Line 42 C
Example.exe!kinc_internal_update_callback() Line 483 C
Example.exe!kinc_internal_frame() Line 577 C
Example.exe!kinc_start() Line 591 C
Example.exe!kickstart(int argc, char * * argv) Line 118 C
Example.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Line 1324 C

@SunDaw
Copy link
Contributor Author

SunDaw commented Feb 18, 2024

Note: sample 09_depth_render_targets works fine, I haven't investigated what it does differently

@RobDangerous
Copy link
Member

Dave gets this for 06 with Vulkan:
Vulkan ERROR: Code 7060244 : Validation Error: [ UNASSIGNED-CoreValidation-Shader-InconsistentSpirv ] Object 0: handle = 0x55555b060ac8, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6bbb14 | SPIR-V module not valid: ID 22[%22] has not been defined %23 = OpVariable %22 Function

@RobDangerous
Copy link
Member

False alarm on that one, Dave uses Kong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants