Kodi shows disabled recordings as upcoming, when they're never going to happen

[ProfYaffle]

As discussed with @Jalle19 on #hts...

Since tvheadend/tvheadend@fa57953, tvh gives the user the ability to disable an unwanted recording event rather than deleting it. This was to prevent the repeated dance of unwanted-delete-EPG match-reschedule-back in the list-unwanted-delete...

However, Kodi still shows the event as upcoming (e.g. "next recording" on the main TV screen) even if it's disabled, as there's no way for the addon to filter out these disabled events.

It appears that @ksooo has already updated the HTSP spec and bumped to v23 to accommodate the enabled flag.

[Jalle19]

@ksooo this sounds like your area of expertise

[ksooo]

IMO two steps are needed for this

1. ksooo@742cefc which I've created almost immediately after this feature was introduced in tvh but IIRC my tests ended up with the result that it was still buggy in tvh (at that time). I commented on the related tvh commits (tvheadend/tvheadend@c05a478#commitcomment-13537005) but never got feedback. Thus, I postponed this commit and did not PR it.
2. Change Kodi core to handle disabled timers correctly, for instance here https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/timers/PVRTimerInfoTag.h#L127

[ksooo]

On second thought, to solve the problem mentioned by @ProfYaffle only step 1 should be enough. Maybe step 2 is not needed at all.

@ProfYaffle maybe you can cherry-pick ksooo@742cefc and do some tests?

[ProfYaffle]

@ksooo No promises, but I can take a look when I get a chance, sure. I've not built the addons from source before, but I'm sure I can cope.

I think the issue you mention is the same as I raised here, btw:

https://tvheadend.org/issues/3196

... apparently fixed (although I haven't tested) in tvheadend/tvheadend@868e648

[ProfYaffle]

wrong button, mutter, mutter

[ProfYaffle]

Okay, I had a look... and have simply dug myself into a hole!

It seems that I can't just clone/build your add-oneshot-timer-enable-support branch because that only builds against Kodi versions since the merge of the Series Recording Support (xbmc/xbmc@36ad006) - which Isengard doesn't have. So I'd need to rebuild and install Kodi to a later master version as well, which is likely to break something...

Backporting this to Isengard doesn't look trivial either given the number of changes and later code refactoring (e.g. to src/HTSPTypes.h).

Thoughts? I may have the wrong end of the stick or be missing something trivial, of course...

[ksooo]

You need a recent Kodi nightly build (Jarvis) and pvr.hts master. Backporting to Isengard is way to much effort.

[ProfYaffle]

... which is what I feared.

<time passes>

Damn, that was harder than I expected...

Jarvis master built. pvr.hts cloned from add-oneshot-timer-enable-support, built and installed. Main Isengard installation not broken...

It would seem that it does indeed fix the issue... the recording events are now listed as 'inactive', and they don't show up on the main Confluence screen as the next recording(s) any more.

Thanks.

---

An aside... it's probably something I'm missing, however, and here probably isn't the right place anyway, but...

It's really hard to get a simple list of upcoming recordings with this Kodi/PVR combination, as you have to look through each individual rule to see if it's matched anything. Deselecting 'group timers' at least lists the events, but still lists all the enabled rules as well - even if they're not matching anything.

I'd have thought a flag or indicator on the 'group timers' view would be useful - to show that a rule has matched some events and thus is worth drilling into. And when the events aren't grouped by timer, then the timers (rules) themselves shouldn't really be shown, or should be shown separately (i.e. not on the same list). If you like, a "rules view" (with flags to say something's matched) vs an "events view".

Anyway, perhaps still a work in progress on master, or perhaps I've missed something entirely!

Cheers...

[ksooo]

It would seem that it does indeed fix the issue... the recording events are now listed as 'inactive', and they don't show up on the main Confluence screen as the next recording(s) any more.

Cool. Thanks for testing. I will PR the code later today.