Added support for oneshot timer enable/disable (HTSP v23 feature), closes #131 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,6 +177,7 @@ namespace tvheadend | |||
| void SetPriority(uint32_t priority) { m_priority = priority; } | |||
|
|
|||
| private: | |||
| uint32_t m_enabled; | |||
There was a problem hiding this comment.
IMO if this is used as a boolean we should store it as that instead of letting the inner workings of HTSP creep up to this level.
There was a problem hiding this comment.
This is how all the "HTSP" types in pvr.hts currently work. They store the htsp types internally, offer setters for htsp types and getters for Kodi types. So, all good imo, because in line with the rest. Okay?
There was a problem hiding this comment.
If that's the case then it's fine, I somehow thought we converted to booleans in other places.
ksooo
force-pushed
the
add-oneshot-timer-enable-support
branch
from
a8a29af
to
a1b0ef2
Compare
|
Added changelog.txt entry (no new version number, though). Good to go? |
ksooo
added a commit
that referenced
this pull request
Nov 10, 2015
Added support for oneshot timer enable/disable (HTSP v23 feature), closes #131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.