You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking to the reference implementation/prototype, we have a helper method _sanitizeQuery. IMO, this is a bad idea, and we should not inject these parameters, but instead require that the user pass them explicitly. If a simpler API is desired, then extending the class/wrapping the constructor with one that provides default values for username and environment seems like a saner approach.
The text was updated successfully, but these errors were encountered:
Looking to the reference implementation/prototype, we have a helper method
_sanitizeQuery
. IMO, this is a bad idea, and we should not inject these parameters, but instead require that the user pass them explicitly. If a simpler API is desired, then extending the class/wrapping the constructor with one that provides default values for username and environment seems like a saner approach.The text was updated successfully, but these errors were encountered: