Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't do magical parameter injection #2

Closed
humanchimp opened this issue Mar 12, 2014 · 0 comments
Closed

don't do magical parameter injection #2

humanchimp opened this issue Mar 12, 2014 · 0 comments

Comments

@humanchimp
Copy link
Contributor

Looking to the reference implementation/prototype, we have a helper method _sanitizeQuery. IMO, this is a bad idea, and we should not inject these parameters, but instead require that the user pass them explicitly. If a simpler API is desired, then extending the class/wrapping the constructor with one that provides default values for username and environment seems like a saner approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant