Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress spins forever on internal error #5

Open
mindplay-dk opened this issue Feb 5, 2019 · 0 comments
Open

Progress spins forever on internal error #5

mindplay-dk opened this issue Feb 5, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@mindplay-dk
Copy link
Contributor

Improve internal error-handling to prevent progress spinners that spin forever.

The case I encountered was a malformed JSON payload in X-ChromeLogger-Data, where an object was passed to table instead of an array, and thus failed to iterate.

Add error-handling to prevent this - basically catch errors while rendering legacy ChromeLogger data, stop the spinner and display an error message.
@mindplay-dk mindplay-dk added the bug Something isn't working label Feb 5, 2019
@bkdotcom bkdotcom mentioned this issue Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mindplay-dk