Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content="" is not rendered properly #35

Closed
webpapaya opened this issue Apr 29, 2016 · 2 comments
Closed

content="" is not rendered properly #35

webpapaya opened this issue Apr 29, 2016 · 2 comments

Comments

@webpapaya
Copy link
Contributor

Input

Stylesheet.create({
  heading: {
    ':before': {  content: "" }
  }
});

Output

._3TCwqu:before{content:;}

Expected Output

._3TCwqu:before{content:"";}

I don't know if we can generalize this concept for empty strings that they're rendered as "" or if content should have a special behaviour?

@webpapaya
Copy link
Contributor Author

just found a work around:

Stylesheet.create({
  heading: {
    ':before': {  content: '""' }
  }
});

I don't know if this issue still needs to be handled or if it should be closed.

@danieljuhl
Copy link
Contributor

I think the latter/your fix is the right thing to do, because you want it to render a string in quotes, as opposed to the normal way of rendering strings in css. I don't see this as an issue, more as something to be aware of. In my opinion, it makes complete sense to double quote the string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants