Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site configuration #30

Closed
wants to merge 2 commits into from
Closed

site configuration #30

wants to merge 2 commits into from

Conversation

amitu
Copy link

@amitu amitu commented Dec 6, 2012

I have implemented the configuration system I proposed. By relying on django configuration we do not have to learn anything about how to access configuration when writing plugins.

@amitu
Copy link
Author

amitu commented Dec 6, 2012

Oops, I should have started using git flow stuff from beginning. I guess I ll have to wait till first pull request is accepted. Next pulls requests would be cleaner I promise :-)

@amitu
Copy link
Author

amitu commented Dec 6, 2012

My justification for not using config.json already there: it contains sensitive data, I expect to checkin config file along with rest in public places. As mentioned in another issue I feel entire s3 support should go in favor of s3cmd based solution, which means we should get rid of config.json, config.py and site.upload() method.

@hypertexthero
Copy link

+1 for ability to set extra site configuration variables. For example, I want to be able to use Markdown Extensions and Typogrify. Currently getting by with requiring typogrify in setup.py and adding it to installed apps in site.py to be able to write posts like these.

@koenbok
Copy link
Collaborator

koenbok commented Jul 9, 2013

I've left this here way too long without commenting, but I'm hesitant to add this because it adds a lot of complexity in my mind (an extra second config file, a new library, a new syntax to understand).

@koenbok koenbok closed this Jul 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants