Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why has the generic type for Cursor been removed? #357

Closed
m0rtalis opened this issue Aug 11, 2023 · 3 comments
Closed

Question: Why has the generic type for Cursor been removed? #357

m0rtalis opened this issue Aug 11, 2023 · 3 comments

Comments

@m0rtalis
Copy link

Hi,
I'm in the process of upgrading from version 2.5.3 to 6.4.3 and noticed that the generic type from the Cursor class has been removed and the current version only returns unknown for the values instead.

For me it seems like the library became, at least for the consumer, less typesafe with the switch to Typescript.
Is there a particular reason for this change?

@kofrasa
Copy link
Owner

kofrasa commented Aug 11, 2023

I don't really recall the motivation but I would guess it was done to encourage explicit casting. We can certainly restore the generic type and default to unknown.

@m0rtalis
Copy link
Author

I would prefer that, thank you.

@kofrasa
Copy link
Owner

kofrasa commented Aug 16, 2023

Resolved in mingo@6.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants