Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default value for the Cookie::$salt #11

Closed
wants to merge 1 commit into from

Conversation

velkymx
Copy link

@velkymx velkymx commented Jan 21, 2013

Set the default value for the Cookie::$salt that is missing from the bootstrap. It was a new requirement that fails the project on initial setup.

@shadowhand
Copy link
Contributor

@shadowhand shadowhand closed this Jan 21, 2013
@velkymx
Copy link
Author

velkymx commented Jan 21, 2013

Yes, I know about how to set it, but it would be nice not to have to go back and have to re-add the code each time. Seems like adding it to default or throwing a better error would be helpful - especially to new users.

@zombor
Copy link
Contributor

zombor commented Jan 21, 2013

There's already an issue about better handling for this. @zeelot was planning on taking care of it. We definitely do not want a default value, as that is a big security problem.

@velkymx
Copy link
Author

velkymx commented Jan 21, 2013

Fair enough. I'll keep poking around. Thanks Zombor!

@piotrbaczek piotrbaczek mentioned this pull request May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants