Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

All scripts and Dockerfiles should use same variables #77

Closed
Smiley73 opened this issue Jul 31, 2019 · 3 comments
Closed

All scripts and Dockerfiles should use same variables #77

Smiley73 opened this issue Jul 31, 2019 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@Smiley73
Copy link
Contributor

Currently we have variables defined in many different places (e.g. kubectl version). We need to make sure we're consistent and pull it all from the same sources. Maybe travis.yml is the right place?

What happens?

If we change a version, we have to change it in many places and most likely will forget one.

What were you expecting to happen?

Changing a version is a simple task in one file.

@etsauer
Copy link
Contributor

etsauer commented Jul 31, 2019

@Smiley73 can you provide some examples?

@seanmalloy seanmalloy modified the milestone: 0.0.2 Aug 1, 2019
@seanmalloy
Copy link
Contributor

The release version variables will get cleaned up as part of #64. I think the scripts/images-pull-push.sh script can probably be removed. I don't think we need this.

@seanmalloy seanmalloy added this to the near-term milestone Sep 12, 2019
@seanmalloy seanmalloy added the bug Something isn't working label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants