Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against FilerException #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

scoheb
Copy link

@scoheb scoheb commented Dec 2, 2015

If an annotation processor is called more than once, you may receive a FilerException.

This protects against that case.

Scott Hebert added 2 commits December 2, 2015 13:38
If an annotation processor is called more than once, you may receive a FilerException.

This protects against that case.
@@ -7,7 +7,7 @@
</parent>

<artifactId>cucumber-annotation-indexer</artifactId>
<version>1.3-SNAPSHOT</version>
<version>1.2-Ericsson.1</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is undesirable

@olivergondza
Copy link

Can you attach said build failure stacktrace?

@scoheb
Copy link
Author

scoheb commented Apr 25, 2016

Here is a stack trace:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] javax.annotation.processing.FilerException: Attempt to reopen a file for path /home/shebert/work/jenkins/plugins/ath-test/target/test-classes/META-INF/annotations/org.jenkinsci.test.acceptance.docker.DockerFixture
[ERROR] javax.annotation.processing.FilerException: Attempt to reopen a file for path /home/shebert/work/jenkins/plugins/ath-test/target/test-classes/META-INF/annotations/org.jenkinsci.test.acceptance.docker.DockerFixture
[INFO] 2 errors

I added a test case here: https://github.com/scoheb/ath-test

Simply do a mvn clean install

@olivergondza
Copy link

Looks good to me otherwise. @kohsuke, can you?

@olivergondza
Copy link

@kohsuke I have forked this under https://github.com/jenkinsci/cucumber-annotation-indexer so we all can improve it. I consider that to be the upstream now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants