Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version shenanigans #13

Closed
roflcopter4 opened this issue Apr 16, 2018 · 2 comments
Closed

Python version shenanigans #13

roflcopter4 opened this issue Apr 16, 2018 · 2 comments

Comments

@roflcopter4
Copy link
Contributor

This is about the tiniest issue ever, but I figured I'd ask anyway. Many platforms (certainly at least ArchLinux and Gentoo) these days use python3 as the standard python implementation. The scripts included are all definitely python2 code and thus the tests fail immediately. It took approximately 3 seconds to type $ perl -pi -e 's/python/python2/g' Makefile scripts/*.py to fix it completely, but it might be nice if you'd incorporate this into the source itself.

Again, not really much of an issue, but worth pointing out anyway.

@kokke
Copy link
Owner

kokke commented Apr 16, 2018

Hi @roflcopter4 and thanks for checking out the project :) I like the idea to be python3 compatible. Would your suggested fix be backward-compatible with machines without python3 installed?

If so, I suggest you make a PR and I'd gladly accept it :) ?

@kokke
Copy link
Owner

kokke commented May 22, 2018

Closing because I merged your PR #14 :)

Thanks again @roflcopter4

@kokke kokke closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants