Allow ViewCtorProp in create_mirror[_view] #5095
Conversation
|
In support of #4792 |
masterleinad
force-pushed
the
view_ctor_prop_create_mirror
branch
from
5cc4602
to
bd05c73
Compare
masterleinad
force-pushed
the
view_ctor_prop_create_mirror
branch
from
c864131
to
fef5f19
Compare
|
Most of the internals are now expressed in terms of a ViewCtorProp overload and there is also such a user-facing overload. In addition to current functionalities, this overload also allows specifying an execution space that avoids some fences depending on #4826. |
| auto mirror_host_view = Kokkos::create_mirror_view( | ||
| Kokkos::view_alloc(Kokkos::HostSpace{}, Kokkos::WithoutInitializing, | ||
| Kokkos::DefaultExecutionSpace{}), | ||
| host_view); |
There was a problem hiding this comment.
can we test the view_alloc(WithoutInitializing) too?
There was a problem hiding this comment.
Sure, see 8c9aefb.
| const I&... arg_prop) { | ||
| return Kokkos::create_mirror(arg_prop..., space, src); | ||
| const Impl::ViewCtorProp<ViewCtorArgs...>& arg_prop) { | ||
| return create_mirror(space, src, arg_prop); |
There was a problem hiding this comment.
did you want to call this here? Or rather add the space to the arg_prop?
| } | ||
|
|
||
| // Create a mirror in a new space | ||
| template <class Space, class T, class... P> | ||
| inline auto create_mirror( | ||
| const Space& space, const Kokkos::Experimental::DynamicView<T, P...>& src) { | ||
| return Impl::create_mirror(space, src); | ||
| return Impl::create_mirror(space, src, Impl::ViewCtorProp<>{}); |
There was a problem hiding this comment.
should we just pass view_alloc(space) in here?
No, I don't think that's possible. implicit conversions are not considered during type deduction, see https://en.cppreference.com/w/cpp/language/template_argument_deduction#Implicit_conversions. The only thing we could do is to derive from |
masterleinad
force-pushed
the
view_ctor_prop_create_mirror
branch
from
0aef131
to
3f1e440
Compare
Following-up on #4826, #4844, and #5035.