Provide ViewCtorProp overload for create_mirror_view_and_copy #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
view_ctor_prop_create_mirror_view_and_copy
branch
from
887b62a
to
f363abb
Compare
crtrott
requested changes
Jul 7, 2022
crtrott
approved these changes
Jul 7, 2022
masterleinad
force-pushed
the
view_ctor_prop_create_mirror_view_and_copy
branch
from
46976fb
to
375a21f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5095, #5035 and #4844. #4826 would help remove more fences here.
This pull request provides a
ViewCtorPropoverload forcreate_mirror_view_and_copythat also allows specifying an execution space to be used in theallocationand thedeep_copy. The existing version is changed to always use an execution space forallocation(but still uses the two-argumentdeep_copy).