Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip N/A values from ffmpeg progress #214

Merged
merged 7 commits into from
Aug 30, 2021
Merged

Conversation

cromefire
Copy link
Contributor

Successor to #213
Fixes #178

@cromefire cromefire marked this pull request as ready for review August 29, 2021 18:06
@cromefire
Copy link
Contributor Author

There you go

@kokorin
Copy link
Owner

kokorin commented Aug 29, 2021

Please, add your name to the list of authors in files you touched.

@cromefire
Copy link
Contributor Author

Do you have any particular format in mind?

@kokorin
Copy link
Owner

kokorin commented Aug 29, 2021

Please, check existing Apache copyrights: Name Surname would be fine

@cromefire
Copy link
Contributor Author

Can only provide you with a username, but that should hopefully be fine. Only for the main code or for the tests too? They don't have a copyright comment currently.

@kokorin
Copy link
Owner

kokorin commented Aug 29, 2021

Username should be enough to confirm your agreement with Apache license. Only in production code: sec/java/main

@cromefire
Copy link
Contributor Author

cromefire commented Aug 29, 2021

Done. Also per GitHub ToS the agreement with the repository license is given automatically when submitting the PR.

@kokorin
Copy link
Owner

kokorin commented Aug 30, 2021

Please, fix You have 1 Checkstyle violation. Probably, it's because credits in license message should be on the same line

@kokorin
Copy link
Owner

kokorin commented Aug 30, 2021

I have checked parsing once again and found, that potentially the issue could be fixed in more generic way (for fffmpeg too) in ParseUtil. I would say that it is possible to check not only for null and empty string, but also for N/A string.

Before:

if (value != null && !value.isEmpty()) {

After:

if (value != null && !value.isEmpty() && !"N/A".equals(value)) {

Could you please also check that?

@cromefire
Copy link
Contributor Author

Done

@kokorin kokorin merged commit 229dede into kokorin:develop Aug 30, 2021
@kokorin
Copy link
Owner

kokorin commented Aug 30, 2021

thank you!

kokorin added a commit that referenced this pull request Aug 31, 2021
Skip N/A values from ffmpeg progress (#214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants