-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip N/A values from ffmpeg progress #214
Conversation
There you go |
Please, add your name to the list of authors in files you touched. |
Do you have any particular format in mind? |
Please, check existing Apache copyrights: Name Surname would be fine |
Can only provide you with a username, but that should hopefully be fine. Only for the main code or for the tests too? They don't have a copyright comment currently. |
Username should be enough to confirm your agreement with Apache license. Only in production code: sec/java/main |
Done. Also per GitHub ToS the agreement with the repository license is given automatically when submitting the PR. |
Please, fix |
I have checked parsing once again and found, that potentially the issue could be fixed in more generic way (for fffmpeg too) in Before: if (value != null && !value.isEmpty()) { After: if (value != null && !value.isEmpty() && !"N/A".equals(value)) { Could you please also check that? |
Done |
thank you! |
Skip N/A values from ffmpeg progress (#214)
Successor to #213
Fixes #178