This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Authentication, authorization and user management #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress implementation of authentication, authorization and user management APIs.
TODO
[ ] Password reset endpoint (POST /api/v1/kolide/user/password/reset)needs_reset
field to user struct[ ] Integrateneeds_reset
into user management endpointuser.Enabled
into authorization checks[ ] Implement MySQL backing store with newsessions
table[ ] Add admin APIs for managing the sessions in the database[ ] Delete all sessions for a user (DELETE /api/v1/kolide/user/session)[ ] Delete a single session for a user (DELETE /api/v1/kolide/user/session/{id})[ ] Go through cookie settings and set modern security flags[ ] Write integration tests for the full login and user management flow[ ] Write a benchmark forJWTRenewalMiddleware
[ ] Write tests forJWTRenewalMiddleware
[ ] Write deeper tests forSessionMiddleware
that stress the failure to set a session and callingGetSession
after that[ ] See if there's a better way to castclaims['user_id']
into a uint other than type asserting it as a float64 first