This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Email-based password reset #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing with MailHogThe request
HTML
Text
Email source
|
|
@zwass this is ready for review. I'm going to add integration testing and react rendering in another PR to keep reviews manageable. |
| @@ -44,15 +44,21 @@ func (vc *ViewerContext) UserID() (uint, error) { | |||
| // CanPerformActions returns a bool indicating the current user's ability to | |||
| // perform the most basic actions on the site | |||
| func (vc *ViewerContext) CanPerformActions() bool { | |||
| if vc.user == nil { | |||
| return false | |||
| if vc.IsLoggedIn() && !vc.user.NeedsPasswordReset { | |||
There was a problem hiding this comment.
I'd prefer to see return vc.IsLoggedIn() && !vc.user.NeedsPasswordReset
|
OK, other than the spam catcher evasion question, the rest of this should be good to go. Moving the email function out even allowed me to use a mock pool object to get another test in. I think I'm using *KolideError properly in I'm going to punt on spam detection avoidance for now and tackle it with DKIM. |
| } | ||
|
|
||
| err = GetSMTPConnectionPool(c).Send(&e, time.Second*10) | ||
| kerr = SendEmail(GetSMTPConnectionPool(c), user.Email, subject, html, text) | ||
| if err != nil { |
There was a problem hiding this comment.
should this be kerr as well?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.