This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Fix logout bug on Safari #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you figure out that this was the problem? |
marpaia
approved these changes
Jan 7, 2017
|
@marpaia I discovered this bug trying to log out on Safari and noticed the console error was that there was a unsupported BodyInit type. Googling around I stumbled across this issue and realized we were not sending JSON as the default parameters although the request headers specify JSON. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking out #786 on Safari and tried to log out as the admin user and log in as the regular user. I was not able to log out on Safari but Chrome worked fine. Looking into it I discovered that we're not correctly sending over a JSON body for the logout request (or any similar post requests with an empty body). This PR conversation the default empty body object to JSON to make the request valid.