Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COSMETIC: Format of Metrics in book card could be improved #45

Closed
karlic opened this issue Sep 23, 2018 · 3 comments
Closed

COSMETIC: Format of Metrics in book card could be improved #45

karlic opened this issue Sep 23, 2018 · 3 comments

Comments

@karlic
Copy link

karlic commented Sep 23, 2018

KyBook 3 v0.5.4 | #94

  1. Tap a book
  2. Tap Read
  3. Scroll through the book
  4. Close the book
  5. Tap the book
  6. Scroll down to 'Metrics' in the book card
  7. It reads 'Read 33% in 7 secs, 6 pages'

For native English speakers, this would read better as:
Read 6 pages (33%) in 7 secs
or, possibly
Read 33% (6 pages ) in 7 secs

@kolyvan
Copy link
Owner

kolyvan commented Sep 24, 2018

Yes, there is definitely some confusion about this metrics.
'Read 33% in 7 secs, 6 pages' - means what a book has 6 pages total and an user finished read 2 pages in 7 seconds.

@karlic
Copy link
Author

karlic commented Sep 24, 2018

OK, so that would read better as:
'Read 33% of 6 pages in 7 secs'
or:
'Read 2 of 6 pages (33%) in 7 secs'

Either way, I think the pages and percent need to be next to each other and not separated by the time.

@kolyvan
Copy link
Owner

kolyvan commented Sep 25, 2018

Fixed in 95 build (v0.5.5)

@kolyvan kolyvan closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants