-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better spongyCastle initialisation / decoupling #22
Comments
This issue now has a bounty-address via issuETH. |
The ContentProvider sounds like a good idea to try. Firebase does the init that way and I remember they had a few problems in the beginning. A link to start one off: https://firebase.googleblog.com/2016/12/how-does-firebase-initialize-on-android.html |
I also do this in WallETH to decouple flavors like this: https://github.com/walleth/walleth/blob/master/app/src/withGeth/java/org/walleth/geth/GethInitContentProvider.kt |
Thinking a bit longer about this: in the end this does not need to be that clean as it will get obsolete with #1 anyway ..-) |
Was recently talking to @cketti recently and I think he is correct that the best way is not to use the providers at all but the lower bouncycastle API - so we do not need the split spongy/bouncy at all. This way we also can avoid the multiple insertProvider calls. |
what do you mean by |
you can directly use the functions without going through providers. So you are sure you do not run into the problem of using varying platform implementations. Will cc you once I make the PR for it |
This is a follow-up for: #21
There are now multiple of these blocks in kethereum:
I would really like a cleaner way of initializing spongyCastle - and ideally a decoupling from sponygCastle from kethereum so it can also be used with bouncyCastle in a JVM context where the whole spongyCastle is not needed.
One Idea:
@mirceanis what do you think?
The text was updated successfully, but these errors were encountered: