kong.client.authenticate should support nil values for consumer and credential

[lvermeire]

go-pdk/client/client.go

Lines 125 to 152 in 4deec45

	// kong.Client.Authenticate() sets the authenticated consumer and/or credential
	// for the current request. While both consumer and credential can be nil,
	// it is required that at least one of them exists. Otherwise this function will throw an error.
	func (c Client) Authenticate(consumer *entities.Consumer, credential *AuthenticatedCredential) error {
	if consumer == nil {
	return fmt.Errorf("Invalid consumer")
	}
	if credential == nil {
	return fmt.Errorf("Invalid credential")
	}
	arg := &kong_plugin_protocol.AuthenticateArgs{
	Consumer: &kong_plugin_protocol.Consumer{
	Id: consumer.Id,
	CreatedAt: int64(consumer.CreatedAt),
	Username: consumer.Username,
	CustomId: consumer.CustomId,
	Tags: consumer.Tags,
	},
	Credential: &kong_plugin_protocol.AuthenticatedCredential{
	Id: credential.Id,
	ConsumerId: credential.ConsumerId,
	},
	}
	err := c.Ask(`kong.client.authenticate`, arg, nil)
	return err
	}

The function kong.client.authenticate in the Kong PDK client module supports nil values for both consumer and credential:

While both consumer and credential can be nil, at least one of them must exist. Otherwise, this function will throw an error.

The current implementation of the go client does not allow either parameter to be nil, but it should.

[StarlightIbuki]

Thanks for the report and the PR! We will be looking into it soon.