Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db) backport postgres schema fix from next to master (only the fix) #4198

Merged
merged 1 commit into from
Jan 14, 2019
Merged

fix(db) backport postgres schema fix from next to master (only the fix) #4198

merged 1 commit into from
Jan 14, 2019

Conversation

bungle
Copy link
Member

@bungle bungle commented Jan 14, 2019

Summary

This backports the fix (#4167) when using non-public schema with Postgres from next to master without adding the new configuration parameter, so that we can apply this to 1.0.1.

hishamhm
hishamhm approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@hishamhm hishamhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this a great building block for adding pg_schema in next on top of this — approved; I will just squash-merge it with a different commit message.

@hishamhm hishamhm merged commit e89d056 into master Jan 14, 2019
@hishamhm hishamhm deleted the fix/backport-pg-schema-fix branch January 14, 2019 20:48
@hishamhm hishamhm added this to the 1.0.1 milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamhm hishamhm hishamhm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@bungle @hishamhm