Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move everything into Kongregate.Web namespace #7

Closed
randomPoison opened this issue Aug 16, 2019 · 1 comment
Closed

Move everything into Kongregate.Web namespace #7

randomPoison opened this issue Aug 16, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@randomPoison
Copy link
Contributor

Currently all items defined in this package are in the global namespace. This is a bad practice for a package since it can lead to name collisions and confusion. We should move all items in the package into the Kongregate.Web namespace.
@randomPoison randomPoison added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 16, 2019
@RichardVasquez
Copy link
Contributor

I'll take a swing at this, and send you a PR.

@RichardVasquez RichardVasquez mentioned this issue Oct 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RichardVasquez @randomPoison