Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change defaults for requestFactory from cozy-konnector-libs #231

Open
edas opened this issue May 15, 2018 · 0 comments
Open

change defaults for requestFactory from cozy-konnector-libs #231

edas opened this issue May 15, 2018 · 0 comments

Comments

@edas
Copy link
Contributor

edas commented May 15, 2018

See https://github.com/konnectors/libs/blob/master/packages/cozy-konnector-libs/src/libs/request.js#L64

Expected result

Unless explicitly requested by the user, any connection with an host with an invalid SSL/TLS certificate.

Actual result

strictSSL is deactivated by default in requestFactory, meaning all invalid certificates won't generate errors. This is not an important issue (it would be very difficult to exploit) but it should not be leaved as is anyway.

This is mandatory for #230 (request/request#1049)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant