Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there was an error with mrujs.confirm #144

Closed
karn18 opened this issue Oct 14, 2021 · 6 comments
Closed

there was an error with mrujs.confirm #144

karn18 opened this issue Oct 14, 2021 · 6 comments
Labels
Type: Bug Something isn't working

Comments

@karn18
Copy link

karn18 commented Oct 14, 2021

Expected Behaviour

Should show confirm dialog after clicked destroy button

Actual Behaviour

It shows an error on console
there was an error with mrujs.confirm

Screenshot from 2021-10-14 14-38-30

Steps to Reproduce

  • create new blogs
  • try to delete one of theme
@karn18 karn18 added the Type: Bug Something isn't working label Oct 14, 2021
@KonnorRogers
Copy link
Owner

Can you confirm that you can use window.confirm("message") on this page?

https://github.com/ParamagicDev/mrujs/blob/e83c192b82df25f60a3a3b796e95db698139c9ec/src/mrujs.ts#L164

https://github.com/ParamagicDev/mrujs/blob/e83c192b82df25f60a3a3b796e95db698139c9ec/src/confirm.ts#L47

In the meantime, I'll create a release which actually logs the error instead of saying there was an error and not showing the error.

@karn18
Copy link
Author

karn18 commented Oct 16, 2021

After trying to call window.confirm("hello") on inspector console, It throws error Uncaught InternalError: too much recursion

Screenshot from 2021-10-16 12-48-48

@KonnorRogers
Copy link
Owner

Do you have a repo I could look at? This looks like something is overriding window.confirm.

@karn18
Copy link
Author

karn18 commented Oct 16, 2021

The repo is here !!!

https://github.com/karn18/abc

@KonnorRogers
Copy link
Owner

@karn18 is this still an issue in the latest v0.8.3? Apologies for leaving you hanging this long.

@karn18
Copy link
Author

karn18 commented Feb 7, 2022

@karn18 is this still an issue in the latest v0.8.3? Apologies for leaving you hanging this long.

@ParamagicDev Now it works well after update to latest version. Thank you.

@karn18 karn18 closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants