Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presence is not requested after accepting subscription #924

Closed
daniele-athome opened this issue Jan 4, 2017 · 0 comments
Closed

Presence is not requested after accepting subscription #924

daniele-athome opened this issue Jan 4, 2017 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@daniele-athome
Copy link
Member

daniele-athome commented Jan 4, 2017

Details at df4963b:

When accepting an invitation, the if below could be false because of delay or no reloading of mConversation at all thus skipping the presence request.
An automatic solution could be to emit a ROSTER_LOADED whenever the roster changes still this if should go away in favour of the message center checking for subscription status and the UI reacting to a pending request status (i.e. "pending_in")

@daniele-athome daniele-athome added the bug Something isn't working label Jan 4, 2017
@daniele-athome daniele-athome added this to the 4.0.0 milestone Jan 4, 2017
@daniele-athome daniele-athome self-assigned this Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant