Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize the fork #12

Closed
ghost opened this issue Jan 26, 2015 · 16 comments
Closed

Finalize the fork #12

ghost opened this issue Jan 26, 2015 · 16 comments

Comments

@ghost
Copy link

ghost commented Jan 26, 2015

I noticed that on the main repo the forked link has been removed, the reason for this I am unsure about, however it does bring up a couple thoughts.

Because of all the search engine indexing on the retired repo, it leads people to think that is no longer maintained/updated without some sort of link. KineticJS beats many other repo's in my opinion for one simple reason, it does not try to copy flash. I could be wrong on some other libraries but most I have seen have tried to mimic the flash api's for this sort of thing. KineticJS stays JS and not being someone who started out in flash, but javascript its the perfect library for me.

So I can see 2 ways of getting through this.

  1. Put more force in the old repo to point to this one.
  2. Start fresh.

If the old repo can continue to point to this one, eventually links and such will move to reflect its new home. Eric did a great job here, but if he is to busy to maintain it I would hate for it to fall into obscurity.

As for starting fresh it would be similar to what other repositories have done with forks, rename them. This way any new documentation will not have to worry about being buried in search pages and it will give it new life. Right now many of the tutorials for KineticJS are actually broken, the examples don't work, so unless they are fixed it would be best to use a new name to bring new tutorials to the top.

I intend to help out with KineticJS however i can, I have noticed a few performance issues that I have been working to get around and would love to contribute that if/when i come up with a solution, however without the main repo being actively maintained, and this one being hard to find unless you visited the repo page when the fork link was there it might not get the attention it needs.

Anyway this is only my opinion.

@lavrton
Copy link
Member

lavrton commented Jan 26, 2015

The reason of removing is pretty simple. I have a message from Eric. My fork as not "official opinion". As he said, one day he may create list of available forks, so link will be returned.

All old tutorials I repaired on home page. http://lavrton.github.io/KineticJS/Getting_Started.html

I was thinking about renaming. But it is REALLY huge work for refactoring and editing manuals. I don't want to spend time for this right now. But it might be good idea.

@ghost
Copy link
Author

ghost commented Jan 26, 2015

I totally understand the renaming lol I have had to do that sometimes and you always miss something and then gotta hunt for it.

Anyway its good to see the reason behind the removing.

Lastly the main reason for me to talk about the docs is that if you google it, the old ones show up and this repo after the link was removed was pretty hard to find. Considering the amount of work you have done with this fork, and the fact I have been unable to find any others I consider this the next official repo but again this is all opinion.

Well with renaming considering Eric's response a rename may be the way to go. If these forks keep the name its going to get confusing very fast. If you are dedicated enough to keep with this then many repo's carrying the name KineticJS all with different features/fixes is going to scare people away.

@vorpalhex
Copy link

I'd like to support the renaming option. I'd be happy enough to start updating stuff if a new name is chosen. It'd also help new people to the project and avoid a lot of the current confusion.

@lavrton
Copy link
Member

lavrton commented Jan 27, 2015

I decided to rename. The name is Konva (without 'js' part).

Finding new name for js framework is almost impossible task. I think this name is nice. Your thoughts?

Now current repo is part of konvajs organization.
New home page available here: http://konvajs.github.io/
Generator for homepage: https://github.com/konvajs/site

Now I am thinking how to organize refactoring and rebranding.

@ghost
Copy link
Author

ghost commented Jan 27, 2015

Sweet!, I will help out with whatever you need. The name seems good, vague enough that as an organization it could support other libraries that work with it.

I am guessing its going to go Kinetic to Konva right?

Most tutorials can be adjusted to fit that for now. as well as naming in the code base.

I have never done anything with hexo but I will start a pull request tomorrow to help with the naming in the code, this should let you focus on it in an overall picture rather then the mule work :).

@ghost ghost mentioned this issue Jan 27, 2015
@irenkai
Copy link

irenkai commented Jan 27, 2015

Will try to help on the renaming initiative. I'll wait for jovination pull to be merged though (lot of grunt work there - awesome dude).

@lavrton
Copy link
Member

lavrton commented Jan 27, 2015

I added tutorials from old repo to home page. Now I am thinking how to replace code snippets (jsbin embeds).

@lavrton
Copy link
Member

lavrton commented Jan 27, 2015

I almost found way to store demos.
It is possible to integrate github and jsfiddle.

From repo: https://github.com/konvajs/konva-demos/blob/master/Shapes/Rect/
We can get this fiddle: http://jsfiddle.net/gh/get/library/pure/konvajs/konva-demos/tree/master/Shapes/Rect/

But a big fail! It is not possible to create embedded snippet from such fiddle.

@lavrton
Copy link
Member

lavrton commented Jan 28, 2015

I will be really happy if someone can help me with replacing jsbin demos with actual Konva snippets.
Some instructions available here: https://github.com/konvajs/site#how-to-help

@ghost
Copy link
Author

ghost commented Jan 29, 2015

I will do what i can.

@ghost
Copy link
Author

ghost commented Jan 29, 2015

@lavrton It seems gulp-jsdoc is having issues with my vagrant environment (ubuntu-64bit), it is not allowing an npm install and it is required to generate.

I can wing it and just edit them, hoping they work in the pull request with no issues though but that might not be the best option.

Is anyone else having this issue? maybe a slightly altered setup for the site (grunt instead of gulp) might help? I don't want to edit tasks just to get it to function for me unless I am sure its not just me. (though this is my first time with a site generator like this).

@lavrton
Copy link
Member

lavrton commented Jan 29, 2015

I forgot to mention that generating is not required. You can update tutorials and demos. I can build and push updates by myself.

@ghost
Copy link
Author

ghost commented Jan 29, 2015

ok, gonna use the couple you did as a template and try to get the rest switched over.

@ghost
Copy link
Author

ghost commented Jan 29, 2015

ok konvajs/site#1 first! lol

@ghost ghost mentioned this issue Jan 29, 2015
@lavrton
Copy link
Member

lavrton commented Feb 2, 2015

I think we are done with forking. I pushed last updates to site. Please review everything.

Large thanks to @jovination and @pgrodrigues.

What do we need at site more? Any other pages, articles?

@lavrton lavrton closed this as completed Feb 2, 2015
@ghost
Copy link
Author

ghost commented Feb 2, 2015

I would say one thing that would be a huge help overall is lessons. Demo's are nice but it does not go deep into the structure of Konva and how things talk to eachother. One big thing many people forget is how javascript passes object by reference and this is what Konva relies on.

I will write a tutorial to explain my idea on it, after i get around my hexo issues ><

Site could use a little cleaning up but its a good start, depends on how you want to brand it of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants