Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on templating language and/or implementation #22

Closed
Tracked by #4
shawn-hurley opened this issue Oct 25, 2022 · 1 comment · Fixed by #51
Closed
Tracked by #4

Decide on templating language and/or implementation #22

shawn-hurley opened this issue Oct 25, 2022 · 1 comment · Fixed by #51
Assignees
Milestone

Comments

@shawn-hurley
Copy link
Contributor

shawn-hurley commented Oct 25, 2022

Today we do not have a defined approach to how to pass templated context values into condition information fields.

Right now, this is the responsibility of the provider, but when moving to external providers, I believe that this needs to become the responsibility of the engine.

I think that for now, we can test out the functionality we do have and this will have to be part of the external provider work.

@shawn-hurley shawn-hurley mentioned this issue Oct 25, 2022
4 tasks
@shawn-hurley shawn-hurley changed the title Decide on templating language and/or implementation. Using go templates is probably not the best thing to do. Decide on templating language and/or implementation Oct 25, 2022
@shawn-hurley shawn-hurley added this to the Demo A milestone Oct 27, 2022
@shawn-hurley
Copy link
Contributor Author

After discussion in the last community call, we decided that mustache was the correct choice for this. I am moving this out of Demo A and into Demo B for implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant