Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long drop downs on modals force scrolling the modal content #1143

Open
sjd78 opened this issue Jul 14, 2023 · 2 comments
Open

Long drop downs on modals force scrolling the modal content #1143

sjd78 opened this issue Jul 14, 2023 · 2 comments

Comments

@sjd78
Copy link
Member

sjd78 commented Jul 14, 2023

This happens in both PF4 and PF5.

Try creating a new tag category:

  • Controls page
  • Tags tab
  • "Create tag category"
  • Open the "Color" drop down

A new scrollbar will appear in the modal content and the drop down contents will be below the visible range.

Having the drop down render below the range of the Modal, but still be fully visible on the page, would be a better experience.

See https://www.patternfly.org/v4/components/select#appending-document-body-vs-parent

Example in PF4:
Screenshot from 2023-07-14 11-44-13

Example in PF5:
Screenshot from 2023-07-14 11-45-36

@punithnayak
Copy link

Hey @sjd78 what you mean is you want the drop down to extend out of the modal?

@sjd78
Copy link
Member Author

sjd78 commented Jul 24, 2023

Hey @sjd78 what you mean is you want the drop down to extend out of the modal?

Yes, but not below the visible range of the view port.

See https://www.patternfly.org/v4/components/select#appending-document-body-vs-parent for some more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants