Become next.js #42
Merged
Become next.js #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petetnt
reviewed
Oct 24, 2019
| import api from "../api"; | ||
| import Loader from "../Loader"; | ||
| //import configFactory from "../../config.js"; | ||
| //const config = configFactory(); |
There was a problem hiding this comment.
Commented lines should be removed
| } | ||
|
|
||
| render() { | ||
| var messages = this.state.messages.map((message, i) => { |
There was a problem hiding this comment.
Tulevan pullarin hommia refaktoroida.
| </div> | ||
| <div | ||
| className="message__body" | ||
| dangerouslySetInnerHTML={{ __html: message.body }} |
There was a problem hiding this comment.
Vakava tietoturva-aukko tässä 👀
| @@ -4,76 +4,38 @@ | |||
| "description": "Koodiklinikka homepage", | |||
| "author": "Riku Rouvila <riku.rouvila@leonidasoy.fi>", | |||
There was a problem hiding this comment.
Tän vois varmaan kanssa päivittää ;)
There was a problem hiding this comment.
riku@okaycodes.fi tai @rikukissa voi varmaa päättää :)
|
Merging to get some momentum on this 🎉 |
This was referenced Oct 24, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be rough corners and such, but at least the page shows up and is identical to the current production page :)
There are some TODO items though; see
TODO.md.